Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarExporter] Suppress deprecations for legacy fixtures#42782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@derrabus
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsPart of#41552
LicenseMIT
Doc PRN/A

Two test fixtures currently trigger a deprecation on PHP 8.1 because they implementSerializable without implementing__serialize() and__unserialize(). However, I believe that we want to test the behavior of the component with this kind of implementation. This why I decided to suppress the deprecation instead of upgrading the fixtures.

@carsonbotcarsonbot added this to the4.4 milestoneAug 29, 2021
@derrabusderrabusforce-pushed thebugfix/suppress-deprecations-for-fixtures branch from25f6233 to01dcc62CompareAugust 29, 2021 20:22
@derrabusderrabus mentioned this pull requestAug 29, 2021
@stof
Copy link
Member

I suggest adding a comment in the code explaining what is done there (that's not self-explanatory right now), which will also allow figuring out that this can be removed once the min PHP requirement allows us to stop caring about that special case.

@derrabus
Copy link
MemberAuthor

I suggest adding a comment in the code explaining what is done there

Will do.

which will also allow figuring out that this can be removed once the min PHP requirement allows us to stop caring about that special case.

That'll be PHP 9 then. 😱

Signed-off-by: Alexander M. Turek <me@derrabus.de>
@derrabusderrabusforce-pushed thebugfix/suppress-deprecations-for-fixtures branch from01dcc62 to2db2c00CompareAugust 30, 2021 16:02
@derrabus
Copy link
MemberAuthor

I've added a longer comment to the custom error handling that should explain what I'm doing.

@derrabusderrabus merged commit460fd35 intosymfony:4.4Aug 31, 2021
@derrabusderrabus deleted the bugfix/suppress-deprecations-for-fixtures branchAugust 31, 2021 12:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

@chalasrchalasrchalasr approved these changes

+1 more reviewer

@TobionTobionTobion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@derrabus@stof@Tobion@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp