Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Match 5.3 and 5.1 mailer configuration#42771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@wizardz
Copy link
Contributor

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#39511
LicenseMIT
Doc PR

Looks like the listener has been in the main config file in 5.1 branch but has not been moved to 5.2 branch during the refactoring.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the titleMatch 5.3 and 5.1 mailer configuration[FrameworkBundle] Match 5.3 and 5.1 mailer configurationAug 29, 2021
@nicolas-grekasnicolas-grekas added this to the5.4 milestoneSep 7, 2021
@nicolas-grekasnicolas-grekas changed the base branch from5.4 to5.3September 7, 2021 07:08
@nicolas-grekasnicolas-grekas changed the base branch from5.3 to5.4September 7, 2021 07:08
@nicolas-grekasnicolas-grekas modified the milestones:5.4,5.3Sep 7, 2021
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(for 5.3)

@nicolas-grekasnicolas-grekas changed the base branch from5.4 to5.3September 7, 2021 07:42
@nicolas-grekas
Copy link
Member

Thank you@wizardz.

@nicolas-grekasnicolas-grekas merged commitdf1cf19 intosymfony:5.3Sep 7, 2021
@fabpotfabpot mentioned this pull requestSep 28, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@lyrixxlyrixxlyrixx approved these changes

@derrabusderrabusderrabus approved these changes

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@jderussejderusseAwaiting requested review from jderusse

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@srozesrozeAwaiting requested review from sroze

@wouterjwouterjAwaiting requested review from wouterj

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

[Mailer] since 5.2.0, testing that an email has been sent with mailer, fails

5 participants

@wizardz@carsonbot@nicolas-grekas@lyrixx@derrabus
[8]ページ先頭
©2009-2025 Movatter.jp