NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpClient] Don't pass float to`usleep()`#42769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

derrabus merged 1 commit into5.3frombugfix/http-client-usleep-precision

Aug 28, 2021

Merged

[HttpClient] Don't pass float to`usleep()`#42769

derrabus merged 1 commit into5.3frombugfix/http-client-usleep-precision

Aug 28, 2021

Conversation

Copy link

Member

derrabus commentedAug 28, 2021

Q	A
Branch?	5.3
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Part of#41552
License	MIT
Doc PR	N/A

When we pass a float value tousleep(), PHP 8.1 will trigger a deprecation warning:

Implicit conversion from float 999967.098236084 to int loses precision

This PR makes the cast explicit and fixes the failing test.

[HttpClient] Don't pass float to usleep()

33424ab

Signed-off-by: Alexander M. Turek <me@derrabus.de>

carsonbot added Status: Needs Review Bug HttpClient labels

Aug 28, 2021

carsonbot added this to the5.3 milestone

Aug 28, 2021

Copy link

carsonbot commentedAug 28, 2021

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot