Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Cast ini_get to an integer to match expected type#42753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
jderusse left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you please provide a test?
Author
natewiebe13 commentedAug 26, 2021
Added. |
jderusse approved these changesAug 26, 2021
stof approved these changesAug 26, 2021
fabpot approved these changesAug 26, 2021
Member
fabpot commentedAug 26, 2021
Thank you@natewiebe13. |
fabpot added a commit that referenced this pull requestAug 26, 2021
…be13)This PR was squashed before being merged into the 4.4 branch.Discussion----------Cast ini_get to an integer to match expected type| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | n/a| License | MIT| Doc PR | n/aThe lifetime value is expected to be an integer, but this is set as a string when using the ini value from `session.cookie_lifetime`. This makes `getLifetime()` return a string instead of an int as the ``@return`` states.Commits-------c56470d Cast ini_get to an integer to match expected type
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lifetime value is expected to be an integer, but this is set as a string when using the ini value from
session.cookie_lifetime. This makesgetLifetime()return a string instead of an int as the@returnstates.