Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[CI] Ensure that all possible@return are turned into native types#42735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
d32b12e to25172d7Compare| - sed -i 's/ *"\*\*\/Tests\/"//' composer.json | ||
| - composer u -o | ||
| - SYMFONY_PATCH_TYPE_DECLARATIONS='force=2' php .github/patch-types.php | ||
| - git diff -U2 composer.json src/ >.github/expected-missing-return-types.diff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
wouldn't this remove those instructions ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
that's right, we'll catch this by reviews I guess :)
25172d7 to2b5cd7aCompare
Uh oh!
There was an error while loading.Please reload this page.
This PR is the final step to close the topic of return types for Symfony 6.
It replaces#42496 bynot adding return types to the classes/interfaces that break cross-component deps.
It enforces that all
@returnfrom 5.4 are turned into native types in 6.0, with the known list of exceptions from#42496.