Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Serializer] Save missing arguments in MissingConstructorArgumentsException#42712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
That'd be for 5.4 yes. Can you please retarget? |
fabpot requested changesSep 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me, can you rebase on current 5.4?
Can you also add a note in the CHANGELOG of the component?
Thanks. Rebased + readme updated, let me know if it's ok |
fabpot approved these changesSep 21, 2021
Thank you@BafS. |
nicolas-grekas added a commit that referenced this pull requestFeb 23, 2023
…ception class with MissingConstructorArgumentException (HypeMC)This PR was merged into the 6.3 branch.Discussion----------[Serializer] Replace the MissingConstructorArgumentsException class with MissingConstructorArgumentException| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | no| New feature? | yes| Deprecations? | yes| Tickets | -| License | MIT| Doc PR | -Followup to#42712.Currently only the missing arguments are saved in the `MissingConstructorArgumentsException`, so there's no way of knowing which class is missing those arguments when nested objects are being deserialized. This PR adds this information to the exception.Also, while working on this I've noticed that the `$missingArguments` argument accepts an array of missing arguments, but only one is ever passed. I'm not sure if this was done intentionally or by accident, but I've changed it so that only one is expected. Please let me know if this change is ok.UPDATE:I've added a new `MissingConstructorArgumentException` class which accepts only one argument and the class name and deprecated the `MissingConstructorArgumentsException` class. However, since the main goal of this PR is to add the class to the exception, I can revert the renaming part if you think the change is not worth it.Commits-------b377c12 [Serializer] Replace the MissingConstructorArgumentsException class with MissingConstructorArgumentException
nicolas-grekas added a commit that referenced this pull requestApr 21, 2023
…rning missing argument one by one (ktherage)This PR was squashed before being merged into the 6.3 branch.Discussion----------[Serializer] Fix MissingConstructorArgumentsException returning missing argument one by one| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -This PR is an improvment of#49013 andfix#42712.She aims to fix the problem reported in#49013 indicating that the method `getMissingConstructorArguments()` of `\Symfony\Component\Serializer\Exception\MissingConstructorArgumentsException` class introduced in#42712 is returning only one missing arguments when there's more than one missing.Commits-------43d028d [Serializer] Fix MissingConstructorArgumentsException returning missing argument one by one
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
It's currently not possible to get the information about which constructor argument is missing (except by doing regex in the exception message string). Having this information is useful when we want to have an input transformer without the need to set every fields to nullable.
For example with this flow:
[request payload] -> [normalizer/unserializer] -> [dto] -> [validation], each field must be nullable to not have exception during the normalization and then we still need to validate, instead we could catchMissingConstructorArgumentsException, handle it and make a nice http exception.Edit: related to#42502