Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Notifier] Firebase error handling#42690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
so the transports doesn't try setting the success message, that doesn't exists.
carsonbot commentedAug 23, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
fabpot commentedAug 23, 2021
Thank you@mishaklomp. |
…sport (villfa)This PR was merged into the 5.3 branch.Discussion----------[Notifier] Fix 'Undefined array key' error in FirebaseTransport| Q | A| ------------- | ---| Branch? | 5.3| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#42841| License | MIT| Doc PR | n/aThis modification fixes a remaining `Undefined array key` error in *FirebaseTransport*.It also add a test to cover#42690.<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/releases): - Always add tests and ensure they pass. - Never break backward compatibility (seehttps://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 5.x. - Changelog entry should followhttps://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry-->Commits-------53f836e [Notifier] Fix 'Undefined array key' error in FirebaseTransport
I found a bug in the Firebase error handling, resulting in a
Undefined index: message_iderror.It occurred when trying to send a notification to an unregistered device token. As I stated in my issue before.
Don't know if this (little) change should include any tests?
This is my first PR, so any feedback is welcome!