Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] add is_enabled option to console.command tag#42679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
chr-hertel wants to merge1 commit intosymfony:5.4fromchr-hertel:command-tag-enabled
Closed

[Console] add is_enabled option to console.command tag#42679

chr-hertel wants to merge1 commit intosymfony:5.4fromchr-hertel:command-tag-enabled

Conversation

@chr-hertel
Copy link
Member

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
Ticketsn/a
LicenseMIT
Doc PRTODO

until now it was not possible to override the$isEnabled = true of theLazyCommand

was originally part of#42580

@ro0NL
Copy link
Contributor

is #[AsCommand] relevant?

@chr-hertel
Copy link
MemberAuthor

is #[AsCommand] relevant?

@ro0NL I don't think so

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedAug 22, 2021•
edited
Loading

What's the purpose vs not putting the tag on the service?

@fabpot
Copy link
Member

@chr-hertel Any feedback regarding@nicolas-grekas's question?

@chr-hertel
Copy link
MemberAuthor

Sorry, yes, we wrote about this and decided to go a different way. changed the implementation of#42580 to remove the service definition instead of using theisEnabled feature. going to close this here!

@nicolas-grekasnicolas-grekas added this to the5.4 milestoneAug 26, 2021
@chr-hertelchr-hertel deleted the command-tag-enabled branchOctober 23, 2022 00:00
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

7 participants

@chr-hertel@ro0NL@nicolas-grekas@fabpot@derrabus@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp