NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Yaml] Use more concise float representation in dump#42668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.4fromdev97:5.4

Sep 19, 2021

Merged

[Yaml] Use more concise float representation in dump#42668

fabpot merged 1 commit intosymfony:5.4fromdev97:5.4

Sep 19, 2021

Conversation

Copy link

Contributor

dev97 commentedAug 21, 2021

Q	A
Branch?	5.4
Bug fix?	no
New feature?	yes
Deprecations?	no
License	MIT

dev97 requested a review fromxabbuh as acode owner

August 21, 2021 10:36

carsonbot added Status: Needs Review Feature Yaml labels

Aug 21, 2021

Copy link

carsonbot commentedAug 21, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

[Yaml] Use more concise float representation in dump

c2248dc

dev97 force-pushed the5.4 branch from25cb69a toc2248dcCompare

August 21, 2021 10:45

Copy link

carsonbot commentedAug 22, 2021

Hey!

I think@gharlan has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

Copy link

Member

fabpot commentedAug 26, 2021

I've no opinion on this one,@xabbuh WDYT?

chalasr added this to the5.4 milestone

Sep 1, 2021

nicolas-grekas approved these changes

Sep 7, 2021

View reviewed changes

src/Symfony/Component/Yaml/Inline.php

		// Preserve float data type since storing a whole number will result in integer value.
		$repr ='!!float'.$repr;
		if (false ===strpos($repr,'E')) {
		$repr =$repr.'.';