Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer] Consume a PSR-14 event dispatcher#42662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@derrabus
Copy link
Member

@derrabusderrabus commentedAug 20, 2021•
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRTODO

This PR proposes to swap our ownEventDispatcherInterface for the PSR-14 one in mailer. This would allow for a deeper integration of the mailer component into non-Symfony applications that use a different event dispatcher, likehttps://github.com/thephpleague/event.

Note that we still need Symfony's event dispatcher as a dependency, mainly because ofEventSubscriberInterface.

@derrabusderrabusforce-pushed theimprovement/mailer-psr-dispatcher branch 2 times, most recently fromab42271 toaa21e5dCompareAugust 20, 2021 13:13
@derrabus
Copy link
MemberAuthor

By the way, should theTransport class be final actually?

@fabpot
Copy link
Member

By the way, should theTransport class be final actually?

You're right, it should be final. Same for the Notifier equivalent class.

derrabus reacted with thumbs up emoji

@fabpot
Copy link
Member

Tests are broken.

@derrabusderrabusforce-pushed theimprovement/mailer-psr-dispatcher branch 3 times, most recently from4c991ec tobd3f9fbCompareAugust 20, 2021 22:10
Signed-off-by: Alexander M. Turek <me@derrabus.de>
@derrabusderrabusforce-pushed theimprovement/mailer-psr-dispatcher branch frombd3f9fb toe3c85b2CompareAugust 20, 2021 22:29
@chalasr
Copy link
Member

Thank you@derrabus.

@chalasrchalasr merged commitbf8ecc4 intosymfony:5.4Aug 20, 2021
@derrabusderrabus deleted the improvement/mailer-psr-dispatcher branchAugust 22, 2021 09:56
fabpot added a commit that referenced this pull requestAug 25, 2021
This PR was merged into the 6.0 branch.Discussion----------[Mailer] Restore Transport signatures| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | Follow-up to#42662| License       | MIT| Doc PR        | N/ACommits-------0d589b9 [Mailer] Restore Transport signatures
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@wouterjwouterjwouterj left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

+1 more reviewer

@doekenorgdoekenorgdoekenorg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

7 participants

@derrabus@fabpot@chalasr@nicolas-grekas@doekenorg@wouterj@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp