Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Translation] Fix message key handling for the Localise provider#42649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
xepozz wants to merge0 commits intosymfony:5.3fromxepozz:fix-localise-provider

Conversation

@xepozz
Copy link
Contributor

@xepozzxepozz commentedAug 19, 2021•
edited by OskarStark
Loading

QA
Branch?5.3 and above
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix #...
LicenseMIT
Doc PR-

Fixed non-recursively merging existing keys and created. Now created keys totally removed by usual merge.
Handled situation when no keys are created in localise service.

@xepozzxepozz changed the base branch from5.4 to5.3August 19, 2021 15:35
@OskarStark
Copy link
Contributor

Thank you for the bugfix, can you please add a testcase to avoid further regressions?

cc@welcoMattic

@carsonbotcarsonbot changed the titleFix localise provider[Translation] Fix localise providerAug 20, 2021
@OskarStarkOskarStark added this to the5.3 milestoneAug 20, 2021
Copy link
Member

@welcoMatticwelcoMattic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It miss tests, but for me it looks good

OskarStark reacted with thumbs up emoji
@xepozz
Copy link
ContributorAuthor

Done

@OskarStark
Copy link
Contributor

@welcoMattic can you please review/test again? Thanks

@derrabus
Copy link
Member

Since the PR title will appear in the ChangeLog of the next release: Can we please find a better one? The current title does not tell me what aspect of the provider needs fixing.

@xepozz
Copy link
ContributorAuthor

How can I help you?
I really need this fix. Can we speed up please?

@fabpotfabpot changed the title[Translation] Fix localise provider[Translation] Fix message key handling for the Localise providerAug 23, 2021
@fabpot
Copy link
Member

Thank you@xepozz.

xepozz reacted with thumbs up emoji

fabpot added a commit that referenced this pull requestAug 23, 2021
…ovider (xepozz)This PR was squashed before being merged into the 5.3 branch.Discussion----------[Translation] Fix message key handling for the Localise provider| Q             | A| ------------- | ---| Branch?       | 5.3 and above| Bug fix?      | yes| New feature?  |no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License       | MIT| Doc PR        | -Fixed non-recursively merging existing keys and created. Now created keys totally removed by usual merge.Handled situation when no keys are created in localise service.Commits-------36b4837 [Translation] Fix message key handling for the Localise provider
@fabpotfabpot closed thisAug 23, 2021
@fabpotfabpotforce-pushed thefix-localise-provider branch fromaee469a to36b4837CompareAugust 23, 2021 09:24
@xepozzxepozz deleted the fix-localise-provider branchAugust 23, 2021 17:51
@fabpotfabpot mentioned this pull requestAug 30, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@welcoMatticwelcoMatticwelcoMattic approved these changes

+1 more reviewer

@MikeDevresseMikeDevresseMikeDevresse approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

7 participants

@xepozz@OskarStark@derrabus@fabpot@welcoMattic@MikeDevresse@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp