Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[ErrorHandler] Turn return-type annotations into deprecations by default + add mode to turn them into native types#42623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromnicolas-grekas:enable-debugclassloaderAug 25, 2021
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
87fa7a8 tof6bc9adCompareUh oh!
There was an error while loading.Please reload this page.
80c5ef4 to1269f85CompareMemberAuthor
nicolas-grekas commentedAug 25, 2021
/cc @symfony/mergers reviews pending 🙏 |
1269f85 to3319eeeCompareUh oh!
There was an error while loading.Please reload this page.
…ult, add mode to turn them into native types
3319eee tobb11e62Comparederrabus approved these changesAug 25, 2021
chalasr approved these changesAug 25, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Leverages#42149
We need extensive doc on the topic for sure, a whole new chapter.
DebugClassLoader allows patching an app or a lib by going through these steps:
symfony/error-handlerif not already therecomposer install -q --optimize-autoloaderpatch-types.phpSYMFONY_PATCH_TYPE_DECLARATIONS='force=phpdoc' php patch-types.phpSYMFONY_PATCH_TYPE_DECLARATIONScan be set to:'force=phpdoc'to copy@returnannotations from parent classes, to express that the next major version of that lib is going to add a native return types;'force=1'to turn@returnannotations into native return types, but only on tests/private/final/internal methods;'force=2'to turn@returnannotations into native return types, for all possible methods.