Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] Fix wrong cache directive when using the new PUBLIC_ACCESS attribute#42596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
91c66dc toa7b370fCompare| $salt =$user->getSalt(); | ||
| if (null !==$salt) { | ||
| if ($salt) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
getSalt() is typehinted as@return string, sonull would be invalid. This check is now also in sync with the same deprecation check inCheckCredentialsListener.
...ecurityBundle/Tests/Functional/Bundle/RememberMeBundle/Security/UserChangingUserProvider.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
a7b370f toca80ee3Compare
Uh oh!
There was an error while loading.Please reload this page.
PUBLIC_ACCESSis the newIS_AUTHENTICATED_ANONYMOUSLYsince 5.2, but we didn't correctly check for this causing a private cache directive for a stateless page.This PR also includes 2 changes from#42595 that could be backported to 5.3