Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix incompatibilities with upcoming security 6.0#42595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 8 commits intosymfony:5.4fromwouterj:pull-41613/backport
Aug 17, 2021

Conversation

@wouterj
Copy link
Member

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?yes
Tickets-
LicenseMIT
Doc PR-

Hats of to the person that invented the flipped tests on a new major branch! All these incompatibility bugs were discovered by the flipped tests of#41613

Security
--------

* Deprecate`AuthenticationEvents::AUTHENTICATION_FAILURE`, use the`LoginFailureEvent` instead
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This event has been deprecated in 5.3, but we forgot to deprecate this constant.

@wouterj
Copy link
MemberAuthor

Build should be green after#42596 is merged (and this PR is rebased).

wouterj added a commit that referenced this pull requestAug 17, 2021
…BLIC_ACCESS attribute (wouterj)This PR was squashed before being merged into the 5.3 branch.Discussion----------[Security] Fix wrong cache directive when using the new PUBLIC_ACCESS attribute| Q             | A| ------------- | ---| Branch?       | 5.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | Ref#41613 (comment)| License       | MIT| Doc PR        | -`PUBLIC_ACCESS` is the new `IS_AUTHENTICATED_ANONYMOUSLY` since 5.2, but we didn't correctly check for this causing a private cache directive for a stateless page.This PR also includes 2 changes from#42595 that could be backported to 5.3Commits-------ca80ee3 [Security] Fix wrong cache directive when using the new PUBLIC_ACCESS attribute
@fabpot
Copy link
Member

@wouterj This one can now be rebased.

@wouterj
Copy link
MemberAuthor

wouterj commentedAug 17, 2021•
edited
Loading

Check, done (andhopefully also fixed the 5.4 branch in this PR)

@fabpot
Copy link
Member

Thank you@wouterj.

@fabpotfabpot merged commitf1643e8 intosymfony:5.4Aug 17, 2021
@wouterjwouterj deleted the pull-41613/backport branchAugust 17, 2021 16:11
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@wouterj@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp