Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[ExpressionLanguage] [Lexer] Remove PHP 8.0 polyfill#42585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromnigelmann:5.3
Aug 19, 2021

Conversation

@nigelmann
Copy link
Contributor

QA
Branch5.3
Bug fixyes
New featureno
Deprecationsno
TicketsFix#42280
LicenseMIT
Doc PRN/A

This is a partial revert of#41576 and is a followup to#42296

Andrej-in-ua reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the title[ExpressionLanguage][Lexer] Remove PHP 8.0 polyfill[ExpressionLanguage] [Lexer] Remove PHP 8.0 polyfillAug 16, 2021
@carsonbot
Copy link

Hey!

I think@Andrej-in-ua has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@nicolas-grekas
Copy link
Member

Can you please share a link or some details about why this change is needed for you?

derrabus reacted with thumbs up emoji

@derrabusderrabus removed their request for reviewAugust 18, 2021 14:51
@nigelmann
Copy link
ContributorAuthor

Sure@nicolas-grekas .

I am having this problem in a TYPO3 installation. I am using theTYPO3-Console and during the first installation thanks to thispackage theTypo3InstallAction is executed and and the error occurs righthere

Hope this helps, let me know if I can do something more

@derrabusderrabus modified the milestones:5.3,4.4Aug 18, 2021
Copy link
Member

@derrabusderrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should apply this change to 4.4 then.

@nicolas-grekas
Copy link
Member

Linking tocomposer/composer#10024 for references.

@nicolas-grekas
Copy link
Member

Thank you@nigelmann.

nigelmann reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commit6ccc63f intosymfony:4.4Aug 19, 2021
This was referencedAug 30, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusAwaiting requested review from derrabus

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@wouterjwouterjAwaiting requested review from wouterj

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@nigelmann@carsonbot@nicolas-grekas@derrabus

[8]ページ先頭

©2009-2025 Movatter.jp