Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[ExpressionLanguage] [Lexer] Remove PHP 8.0 polyfill#42585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedAug 16, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot commentedAug 17, 2021
Hey! I think@Andrej-in-ua has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
nicolas-grekas commentedAug 18, 2021
Can you please share a link or some details about why this change is needed for you? |
nigelmann commentedAug 18, 2021
Sure@nicolas-grekas . I am having this problem in a TYPO3 installation. I am using theTYPO3-Console and during the first installation thanks to thispackage theTypo3InstallAction is executed and and the error occurs righthere Hope this helps, let me know if I can do something more |
derrabus left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should apply this change to 4.4 then.
nicolas-grekas commentedAug 19, 2021
Linking tocomposer/composer#10024 for references. |
nicolas-grekas commentedAug 19, 2021
Thank you@nigelmann. |
This is a partial revert of#41576 and is a followup to#42296