Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] Add authenticators info to the profiler#42582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
wouterj commentedAug 15, 2021
Nice! This would fix#36668 (maybe there are some ideas in there that you didn't think of). On a related note: I think it would make sense to start using tabs (like on the request page), instead of putting everything (voting, authenticators, firewall config, etc) on a single page. |
wouterj commentedAug 15, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
And a DX thing that we probably should not try to fix in this PR: the information of this profiler will mostly be useful for the routes doing authentication. We should maybe introduce a way to link to profilers of previous requests from the toolbar (maybe even show some info), as e.g. you'll never get to see the profiler data of the actual login requests in the login form (as you're always redirected - either back to the form or to the target page).
|
chalasr commentedAug 15, 2021
I totally forgot about that issue, thank you.
Definitely, I’ll create an issue for that. |
769aa64 tod0ca257Comparefc17f10 to3095273Comparef9fbdf4 to8789469Compare8789469 to3ec5e96Comparechalasr commentedOct 10, 2021
Now with tests. Also the security panel content is now split in several tabs, as suggested by Wouter. PR ready! |
fabpot commentedOct 11, 2021
Thank you@chalasr. |
Uh oh!
There was an error while loading.Please reload this page.
The profiler's security panel needs an update regarding the not-so-new authenticator manager system.

Here it is: