Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Security] Add authenticators info to the profiler#42582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromchalasr:authenticator-profiler
Oct 11, 2021

Conversation

@chalasr
Copy link
Member

@chalasrchalasr commentedAug 15, 2021
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

The profiler's security panel needs an update regarding the not-so-new authenticator manager system.
Here it is:
Screenshot 2021-10-10 at 21 09 40

Guikingone, weaverryan, mtarld, yceruto, chapterjason, wouterj, and apfelbox reacted with rocket emojiwouterj reacted with eyes emoji
@carsonbotcarsonbot changed the title[Security][WIP] Add authenticators info to the profiler[Security] [WIP] Add authenticators info to the profilerAug 15, 2021
@wouterj
Copy link
Member

Nice! This would fix#36668 (maybe there are some ideas in there that you didn't think of).

On a related note: I think it would make sense to start using tabs (like on the request page), instead of putting everything (voting, authenticators, firewall config, etc) on a single page.

@wouterj
Copy link
Member

wouterj commentedAug 15, 2021
edited
Loading

And a DX thing that we probably should not try to fix in this PR: the information of this profiler will mostly be useful for the routes doing authentication. We should maybe introduce a way to link to profilers of previous requests from the toolbar (maybe even show some info), as e.g. you'll never get to see the profiler data of the actual login requests in the login form (as you're always redirected - either back to the form or to the target page).

</braindump about profiler improvements for new security> 😉

@chalasr
Copy link
MemberAuthor

I totally forgot about that issue, thank you.
About the need for improving this screen, I agree. I’ll take some inspiration from other panels. I’d welcome any suggestion also (/cc@javiereguiluz).

We should maybe introduce a way to link to profilers of previous requests from the toolbar (maybe even show some info), as e.g. you'll never get to see the profiler data of the actual login requests in the login form (as you're always redirected - either back to the form or to the target page).

Definitely, I’ll create an issue for that.

@nicolas-grekasnicolas-grekas added this to the5.4 milestoneAug 18, 2021
@chalasrchalasrforce-pushed theauthenticator-profiler branch 8 times, most recently fromfc17f10 to3095273CompareOctober 10, 2021 15:01
@chalasrchalasr changed the title[Security] [WIP] Add authenticators info to the profiler[Security] Add authenticators info to the profilerOct 10, 2021
@chalasrchalasrforce-pushed theauthenticator-profiler branch 5 times, most recently fromf9fbdf4 to8789469CompareOctober 10, 2021 16:13
@chalasr
Copy link
MemberAuthor

Now with tests. Also the security panel content is now split in several tabs, as suggested by Wouter.
(diff best viewed without whitespaceshttps://github.com/symfony/symfony/pull/42582/files?w=1)

PR ready!

@fabpot
Copy link
Member

Thank you@chalasr.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@wouterjwouterjAwaiting requested review from wouterj

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@chalasr@wouterj@fabpot@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp