Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console][FrameworkBundle] Add DotenvDebugCommand#42580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromchr-hertel:dotenv-debug-command
Oct 16, 2021
Merged

[Console][FrameworkBundle] Add DotenvDebugCommand#42580

fabpot merged 1 commit intosymfony:5.4fromchr-hertel:dotenv-debug-command
Oct 16, 2021

Conversation

@chr-hertel
Copy link
Member

@chr-hertelchr-hertel commentedAug 15, 2021•
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#41958
LicenseMIT
Doc PRsymfony/symfony-docs#15734

Bildschirmfoto von 2021-08-15 13-57-48

  • Command Implementation
  • Tests
  • Docs

ro0NL, Guikingone, ogizanagi, noniagriconomie, simonberger, apfelbox, derrabus, sstok, hason, yceruto, and 2 more reacted with thumbs up emojiOskarStark, derrabus, and yceruto reacted with rocket emoji
Copy link
Contributor

@ro0NLro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(yes i want this 😁 )

OskarStark reacted with thumbs up emojichr-hertel reacted with heart emoji
Copy link
Contributor

@ro0NLro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(travis failure is a pesky newline ;))

Copy link
Member

@derrabusderrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Note that the Dotenv component might not be installed in a Symfony application. This new command should probably…

  • not be wired byFrameworkExtension
  • output a nice error message

… if the component is unavailable.

chr-hertel and sstok reacted with thumbs up emoji
@chr-hertel
Copy link
MemberAuthor

chr-hertel commentedAug 20, 2021•
edited
Loading

@derrabus would it be sufficient to extend theisEnabled() to not only check for$_SERVER['SYMFONY_DOTENV_VARS'] but also addclass_exists(DotEnv::class)?

edit: needed some additional changes toAddConsoleCommandPass to makeisEnabled really count ... not really sure about that

@derrabusderrabus changed the title[Dotenv] Adding DotenvDebugCommand[Dotenv] Add DotenvDebugCommandAug 22, 2021
@derrabus
Copy link
Member

We should add a line to FrameworkBundle's ChangeLog:

* Add DotenvDebugCommand

And since your changes to FrameworkBundle rely on theis_enabled attribute you've added to the Console component, FrameworkBundle should conflict with

"symfony/console": "<5.4",
chr-hertel reacted with thumbs up emoji

@carsonbotcarsonbot changed the title[Dotenv] Add DotenvDebugCommand[Console][FrameworkBundle] Add DotenvDebugCommandAug 22, 2021
@fabpot
Copy link
Member

What about moving this command to the Dotenv component (that's what we are doing for component related commands)?

chalasr, ro0NL, chr-hertel, derrabus, and yceruto reacted with thumbs up emoji

@chr-hertelchr-hertel changed the title[Console][FrameworkBundle] Add DotenvDebugCommand[DotEnv][FrameworkBundle] Add DotenvDebugCommandAug 22, 2021
@chr-hertelchr-hertel changed the title[DotEnv][FrameworkBundle] Add DotenvDebugCommand[Dotenv][FrameworkBundle] Add DotenvDebugCommandAug 22, 2021
@carsonbotcarsonbot changed the title[Dotenv][FrameworkBundle] Add DotenvDebugCommand[Console][FrameworkBundle] Add DotenvDebugCommandAug 29, 2021
@derrabus
Copy link
Member

@symfony/mergers Is there anything left to do here? From my POV, this PR is ready to be merged.

Copy link
Member

@ycerutoyceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice addition!

@fabpot
Copy link
Member

Thank you@chr-hertel.

chr-hertel reacted with hooray emoji

@fabpotfabpot merged commitf1b8b6e intosymfony:5.4Oct 16, 2021
@chr-hertelchr-hertel deleted the dotenv-debug-command branchOctober 18, 2021 16:30
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestOct 26, 2021
…d (chr-hertel)This PR was merged into the 5.4 branch.Discussion----------[Dotenv] extending env var list with debug:dotenv commandWas not sure about where to put this ...symfony/symfony#42580Commits-------77d5506 extending env var list with debug:dotenv command
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrchalasr left review comments

@fabpotfabpotfabpot approved these changes

@derrabusderrabusderrabus approved these changes

@ycerutoycerutoyceruto approved these changes

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

+2 more reviewers

@ro0NLro0NLro0NL approved these changes

@noniagriconomienoniagriconomienoniagriconomie left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[DotEnv] Additional debug command to get more info about the vars and files

9 participants

@chr-hertel@derrabus@fabpot@nicolas-grekas@ro0NL@yceruto@chalasr@noniagriconomie@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp