Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] Sort services in service locator according to priority#42532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
BoShurik wants to merge1 commit intosymfony:5.4fromBoShurik:tagged-locator
Closed

Conversation

@BoShurik
Copy link
Contributor

@BoShurikBoShurik commentedAug 13, 2021•
edited by nicolas-grekas
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#42506
LicenseMIT
Doc PR-

derrabus reacted with thumbs up emoji
}
$refMap[$id] =newServiceClosureArgument($ref);
}
ksort($refMap);
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As I understand sort here is for easy testing

@carsonbot
Copy link

Hey!

I think@fancyweb has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@nicolas-grekasnicolas-grekas added this to the5.4 milestoneAug 18, 2021
@carsonbotcarsonbot changed the titleSort services in service locator according to priority[DependencyInjection] Sort services in service locator according to priorityAug 18, 2021
@nicolas-grekas
Copy link
Member

Can you please add a test case that covers the new behavior?

@nicolas-grekas
Copy link
Member

Oh, and please have a look at failing test cases.

@nicolas-grekas
Copy link
Member

Friendly ping@BoShurik

@BoShurik
Copy link
ContributorAuthor

@nicolas-grekas yes, it's in my todo-list for this week

@BoShurik
Copy link
ContributorAuthor

@nicolas-grekas I am not sure how to fix7.4, high-deps tests.
As I understand in this case my changes inDependencyInjection used as a dependency forHttpKernel tests and those tests falls
So we need to excludesymfony/dependency-injection: 5.4 forsymfony/http-kernel: 4.4. Is it possible?

@nicolas-grekas
Copy link
Member

So we need to exclude symfony/dependency-injection: 5.4 for symfony/http-kernel: 4.4. Is it possible?

no need to exclude: we should patch 4.4 instead to relax the test case, which is too strict apparently

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(but please send a PR for 4.4 to relax the tests)

@fabpot
Copy link
Member

Thank you@BoShurik.

fabpot added a commit that referenced this pull requestSep 10, 2021
… according to priority (BoShurik)This PR was merged into the 5.4 branch.Discussion----------[DependencyInjection] Sort services in service locator according to priority| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       |Fix#42506| License       | MIT| Doc PR        | -Commits-------c67c2df Sort services in service locator according to priority
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[DependencyInjection] Priority ignored for tagged locator

4 participants

@BoShurik@carsonbot@nicolas-grekas@fabpot
[8]ページ先頭
©2009-2025 Movatter.jp