Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] Deprecate built-in authentication entry points#42516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromwouterj:pull-41613/entry-point
Aug 16, 2021

Conversation

@wouterj
Copy link
Member

QA
Branch?5.4
Bug fix?no
New feature?no
Deprecations?yes
TicketsRef#41613
LicenseMIT
Doc PRtbd

The last item from#41613.

Entry point logic is now included in the related build in authenticators, we should deprecate these unused classes (and remove them in 6.0). The interface has to be kept, as this implemented by the authenticators (and can be used to customize the entry points in an app).

I've also deprecated the retry entry point and included the code inChannelListener directly. This entry point has never made sense to me, as it's not related to authentication imho.

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you. I've just have one question.

Apart from that Im happy with the PR.

@javiereguiluzjaviereguiluz changed the title[Security] Deprecated build-in authentication entry points[Security] Deprecated built-in authentication entry pointsAug 13, 2021
@wouterjwouterjforce-pushed thepull-41613/entry-point branch from9ca3cc7 toc85faddCompareAugust 14, 2021 18:28
@wouterj
Copy link
MemberAuthor

Psalm error is expected (due to the BC layer). This PR is ready

@wouterjwouterjforce-pushed thepull-41613/entry-point branch 2 times, most recently from3dd4145 to85eee2fCompareAugust 15, 2021 11:39
This logic is now included in the authenticators
@wouterjwouterjforce-pushed thepull-41613/entry-point branch from85eee2f toc247b37CompareAugust 15, 2021 12:35
@fabpotfabpot changed the title[Security] Deprecated built-in authentication entry points[Security] Deprecate built-in authentication entry pointsAug 16, 2021
@fabpot
Copy link
Member

Thank you@wouterj.

@fabpotfabpot merged commit7f63fff intosymfony:5.4Aug 16, 2021
@wouterjwouterj deleted the pull-41613/entry-point branchAugust 16, 2021 08:06
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@NyholmNyholmNyholm requested changes

@fabpotfabpotfabpot approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wouterj@fabpot@Nyholm@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp