Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] add return types#42513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?6.0
Bug fix?no
New feature?yes
Deprecations?no
Tickets#40154
LicenseMIT
Doc PR-

Extracted from#42496

Not all possible return types are patched for the attached components, to save breaking BC cross-components, for now at least.

@wouterj
Copy link
Member

If I'm correct, these changes are all automated (correct me if I'm wrong). In that case, I would appreciate it if this could be merged after#41613, to avoid merge conflicts (I'm currently working on the last 5.4 PR that is blocking the merge).

@nicolas-grekas
Copy link
MemberAuthor

Works for me, I'll rebase after.
(Changes are semi-automated)

wouterj reacted with heart emoji

@StaffNowa
Copy link
Contributor

By the way fabbot not happy 😃😊

@nicolas-grekasnicolas-grekasforce-pushed thereturn-types-sec branch 8 times, most recently from3ad6d62 to077a238CompareAugust 18, 2021 13:21
Copy link
MemberAuthor

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

/cc@wouterj here are some comments for you I guess (+ review welcome of course :) )

@nicolas-grekasnicolas-grekasforce-pushed thereturn-types-sec branch 4 times, most recently fromd003dfa tob71fa54CompareAugust 20, 2021 09:48
nicolas-grekas added a commit that referenced this pull requestAug 20, 2021
…ekas)This PR was merged into the 5.4 branch.Discussion----------[Security] fix restrictive return annotation| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -See#42513 (comment) for rationale.Commits-------974e4ba [Security] fix restrictive return annotation
symfony-splitter pushed a commit to symfony/security-http that referenced this pull requestAug 20, 2021
…ekas)This PR was merged into the 5.4 branch.Discussion----------[Security] fix restrictive return annotation| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Seesymfony/symfony#42513 (comment) for rationale.Commits-------974e4ba23d [Security] fix restrictive return annotation
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@wouterjwouterjwouterj left review comments

@chalasrchalasrchalasr left review comments

Assignees

No one assigned

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas@wouterj@StaffNowa@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp