Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Add return types - batch 6/n#42511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
7613e3d to53230f2CompareMemberAuthor
nicolas-grekas commentedAug 12, 2021
Help wanted to fix psalm failures |
carsonbot commentedAug 13, 2021
Hey! I think@fancyweb has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
Contributor
Tobion commentedAug 13, 2021
#42537 should fix those |
nicolas-grekas added a commit that referenced this pull requestAug 16, 2021
This PR was merged into the 5.4 branch.Discussion----------[Form] Fix return types in form builder| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets || License | MIT| Doc PR |Fix return types incompatibilities found by psalm in#42511> Error: The declared return type 'Symfony\Component\EventDispatcher\EventDispatcherInterface' for Symfony\Component\Form\ButtonBuilder::getEventDispatcher is not nullable, but 'null' contains null (seehttps://psalm.dev/144)Error: The declared return type 'string' for Symfony\Component\Form\ButtonBuilder::getAction is not nullable, but 'null' contains null (seehttps://psalm.dev/144)Error: The declared return type 'string' for Symfony\Component\Form\ButtonBuilder::getMethod is not nullable, but 'null' contains null (seehttps://psalm.dev/144)Error: The declared return type 'Symfony\Component\Form\RequestHandlerInterface' for Symfony\Component\Form\ButtonBuilder::getRequestHandler is not nullable, but 'null' contains null (seehttps://psalm.dev/144)Error: The declared return type 'Symfony\Component\Form\FormFactoryInterface' for Symfony\Component\Form\FormConfigBuilder::getFormFactory is not nullable, but 'Symfony\Component\Form\FormFactoryInterface|null' contains null (seehttps://psalm.dev/144)Error: The declared return type 'string' for Symfony\Component\Form\FormConfigBuilder::getAction is not nullable, but 'null|string' contains null (seehttps://psalm.dev/144)Commits-------ea606ea [Form] Fix return types in form builder
53230f2 toeb138ebCompareUh oh!
There was an error while loading.Please reload this page.
dcfdae8 tof7403f2Comparef7403f2 todf6b42eCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from#42496
Not all possible return types are patched for the attached components, to save breaking BC cross-components, for now at least.