Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add return types - batch 6/n#42511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.0fromnicolas-grekas:return-types-6
Aug 16, 2021

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?6.0
Bug fix?no
New feature?yes
Deprecations?no
Tickets#40154
LicenseMIT
Doc PR-

Extracted from#42496

Not all possible return types are patched for the attached components, to save breaking BC cross-components, for now at least.

@nicolas-grekas
Copy link
MemberAuthor

Help wanted to fix psalm failures

@carsonbot
Copy link

Hey!

I think@fancyweb has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@Tobion
Copy link
Contributor

Help wanted to fix psalm failures

#42537 should fix those

nicolas-grekas reacted with heart emoji

nicolas-grekas added a commit that referenced this pull requestAug 16, 2021
This PR was merged into the 5.4 branch.Discussion----------[Form] Fix return types in form builder| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       || License       | MIT| Doc PR        |Fix return types incompatibilities found by psalm in#42511> Error: The declared return type 'Symfony\Component\EventDispatcher\EventDispatcherInterface' for Symfony\Component\Form\ButtonBuilder::getEventDispatcher is not nullable, but 'null' contains null (seehttps://psalm.dev/144)Error: The declared return type 'string' for Symfony\Component\Form\ButtonBuilder::getAction is not nullable, but 'null' contains null (seehttps://psalm.dev/144)Error: The declared return type 'string' for Symfony\Component\Form\ButtonBuilder::getMethod is not nullable, but 'null' contains null (seehttps://psalm.dev/144)Error: The declared return type 'Symfony\Component\Form\RequestHandlerInterface' for Symfony\Component\Form\ButtonBuilder::getRequestHandler is not nullable, but 'null' contains null (seehttps://psalm.dev/144)Error: The declared return type 'Symfony\Component\Form\FormFactoryInterface' for Symfony\Component\Form\FormConfigBuilder::getFormFactory is not nullable, but 'Symfony\Component\Form\FormFactoryInterface|null' contains null (seehttps://psalm.dev/144)Error: The declared return type 'string' for Symfony\Component\Form\FormConfigBuilder::getAction is not nullable, but 'null|string' contains null (seehttps://psalm.dev/144)Commits-------ea606ea [Form] Fix return types in form builder
@nicolas-grekasnicolas-grekasforce-pushed thereturn-types-6 branch 6 times, most recently fromdcfdae8 tof7403f2CompareAugust 16, 2021 15:39
@nicolas-grekasnicolas-grekas merged commit2aebc94 intosymfony:6.0Aug 16, 2021
@nicolas-grekasnicolas-grekas deleted the return-types-6 branchAugust 16, 2021 15:55
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

1 more reviewer

@TobionTobionTobion left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolas-grekas@carsonbot@Tobion

[8]ページ先頭

©2009-2025 Movatter.jp