Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Add return types - batch 5/n#42509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
f6d0b54 tobaeab7cCompareMemberAuthor
nicolas-grekas commentedAug 12, 2021
I would greatly appreciate any help on this one to fix the failing test cases. |
baeab7c to1c17b35CompareMemberAuthor
nicolas-grekas commentedAug 12, 2021
Problematic part moved to#42512 |
1c17b35 to00f08e4Comparederrabus added a commit that referenced this pull requestJul 4, 2024
This PR was merged into the 7.2 branch.Discussion----------[Routing] Remove dead `is_object()` check| Q | A| ------------- | ---| Branch? | 7.2| Bug fix? | no| New feature? | no| Deprecations? | no| Issues | N/A| License | MITRight after we call `ObjectLoader::getObject()`, we check if the returned value is actually an object. Since 6.0 (#42509), that method has a native return type of `object`, so we can be pretty sure that we won't ever not hold an object in our hands here.Commits-------f734932 [Router] Remove dead is_object() check
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from#42496
Not all possible return types are patched for the attached components, to save breaking BC cross-components, for now at least.