Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add return types - batch 1/n#42504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.0fromnicolas-grekas:return-types-1
Aug 13, 2021

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedAug 12, 2021•
edited
Loading

QA
Branch?6.0
Bug fix?no
New feature?yes
Deprecations?no
Tickets#40154
LicenseMIT
Doc PR-

Extracted from#42496 for components that shouldn't be extended very often.

@nicolas-grekas
Copy link
MemberAuthor

📗 (psalm failure are false-positives here.)

* @return CacheItemPoolInterface
*/
publicstaticfunctioncreate(string$file,CacheItemPoolInterface$fallbackPool)
publicstaticfunctioncreate(string$file,CacheItemPoolInterface$fallbackPool):CacheItemPoolInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
publicstaticfunction create(string$file,CacheItemPoolInterface$fallbackPool):CacheItemPoolInterface
publicstaticfunction create(string$file,CacheItemPoolInterface$fallbackPool):static

I don't quite understand why the previously annotated return type was so wide, tbh.

@nicolas-grekasnicolas-grekas merged commitda0ad85 intosymfony:6.0Aug 13, 2021
@nicolas-grekasnicolas-grekas deleted the return-types-1 branchAugust 13, 2021 09:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

@jderussejderusseAwaiting requested review from jderussejderusse is a code owner

@lyrixxlyrixxAwaiting requested review from lyrixxlyrixx is a code owner

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolas-grekas@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp