Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add generic types to traversable implementations#42471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@derrabus
Copy link
Member

@derrabusderrabus commentedAug 10, 2021•
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?kinda
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRN/A

Since tool support for generic types is growing, I wanted to give it a try and add generics to our traversable implementations. This should help Psalm to understand our code better. Furthermore, it helps app developers with running static code analysis on their own codebases.

Marking this as WIP for now until I reviewed all errors reported by Psalm.

franmomu and wouterj reacted with thumbs up emojiKocal, ging-dev, zmitic, and rvanlaak reacted with heart emoji
@nicolas-grekasnicolas-grekas added this to the5.4 milestoneAug 11, 2021
@lyrixx
Copy link
Member

👍🏼 for the workflow part

@nicolas-grekas
Copy link
Member

Ldap's QueryInterface declares@return CollectionInterface|Entry[] but it should be something like@return CollectionInterface<Entry>

derrabus reacted with eyes emoji

@derrabusderrabusforce-pushed theimprovement/generic-iterators branch 8 times, most recently from0b5c0de to170a802CompareAugust 12, 2021 22:22
@derrabusderrabusforce-pushed theimprovement/generic-iterators branch 4 times, most recently from5a761ed to9a03d29CompareAugust 18, 2021 23:02
@derrabusderrabusforce-pushed theimprovement/generic-iterators branch from9a03d29 to591b066CompareAugust 28, 2021 18:05
@derrabusderrabusforce-pushed theimprovement/generic-iterators branch from591b066 to7f824fcCompareNovember 3, 2021 09:25
@fabpotfabpot changed the titleWIP: Add generic types to traversable implementationsAdd generic types to traversable implementationsNov 3, 2021
@fabpot
Copy link
Member

Thank you@derrabus.

@fabpotfabpot merged commita74fdac intosymfony:5.4Nov 3, 2021
@derrabusderrabus deleted the improvement/generic-iterators branchNovember 3, 2021 11:00
@derrabusderrabus mentioned this pull requestNov 3, 2021
fabpot added a commit that referenced this pull requestNov 4, 2021
This PR was merged into the 5.4 branch.Discussion----------Fix more generic types| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | N/A| License       | MIT| Doc PR        | N/ASome changes I wanted to push to#42471, but then it got merged already. 😇Commits-------c54d61e Fix more generic types
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@lyrixxlyrixxAwaiting requested review from lyrixxlyrixx is a code owner

@srozesrozeAwaiting requested review from sroze

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

@wouterjwouterjAwaiting requested review from wouterj

+1 more reviewer

@franmomufranmomufranmomu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

7 participants

@derrabus@lyrixx@nicolas-grekas@fabpot@stof@franmomu@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp