Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Notifier] Add more explicit error if a SMSChannel doesn't have a Recipient#42433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Notifier] Add more explicit error if a SMSChannel doesn't have a Recipient#42433
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Nyholm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for this PR.
Uh oh!
There was an error while loading.Please reload this page.
81411d6 to45d577fCompare
fabpot left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nvm
fabpot commentedAug 23, 2021
Thank you@ismail1432. |
Improve error message if a
SmSChanneldoesn't have a Recipient. ATM The snippet bellow output the message:The "sms" channel is not supported.because theSmsChannel::supportsreturnfalseif you pass an instance ofNoRecipient.This PR improve the error message with : "The "sms" channel needs a Recipient."