Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Notifier] Add more explicit error if a SMSChannel doesn't have a Recipient#42433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@ismail1432
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?yes
LicenseMIT

Improve error message if aSmSChannel doesn't have a Recipient. ATM The snippet bellow output the message:
The "sms" channel is not supported. because theSmsChannel::supports returnfalse if you pass an instance ofNoRecipient.

This PR improve the error message with : "The "sms" channel needs a Recipient."

<?php$notifier =newNotifier(['sms' =>newSmsChannel(newNullTransport())]);$notifier->send(newNotification("Hello World!", ["sms/twilio"]));

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for this PR.

ismail1432 reacted with thumbs up emoji
@chalasrchalasr added this to the5.4 milestoneAug 9, 2021
@ismail1432ismail1432force-pushed theimprove-exception-for-sms-without-recipient branch from81411d6 to45d577fCompareAugust 9, 2021 15:05
Copy link
Member

@fabpotfabpot left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nvm

@fabpot
Copy link
Member

Thank you@ismail1432.

@fabpotfabpot merged commit8220795 intosymfony:5.4Aug 23, 2021
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@NyholmNyholmNyholm left review comments

@fabpotfabpotfabpot approved these changes

@jderussejderussejderusse approved these changes

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

6 participants

@ismail1432@fabpot@jderusse@Nyholm@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp