Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpFoundation] Mark Request::get() internal#42392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromro0NL:patch-1
Aug 6, 2021
Merged

[HttpFoundation] Mark Request::get() internal#42392

fabpot merged 1 commit intosymfony:5.4fromro0NL:patch-1
Aug 6, 2021

Conversation

@ro0NL
Copy link
Contributor

QA
Branch?5.4
Bug fix?no
New feature?no
Deprecations?yes
TicketsFix#40984
LicenseMIT
Doc PRsymfony/symfony-docs#...

we should not forget about this :)

TomasVotruba reacted with thumbs up emoji
@ro0NL
Copy link
ContributorAuthor

yeah much internal usage.

no time to do such maintenance, sorry. Feel free to takeover.

derrabus reacted with laugh emoji

@ro0NL
Copy link
ContributorAuthor

@internal also works for me, i can do that quick 👍

@ro0NLro0NL changed the title[HttpFoundation] Deprecate Request::get()[HttpFoundation] Mark Request::get() internalAug 5, 2021
@ro0NL
Copy link
ContributorAuthor

to make this PR actionable, i chosen@internal approach.

The goal to me is to get this method out of public API scope.

@chalasrchalasr added this to the5.4 milestoneAug 5, 2021
@Nyholm
Copy link
Member

Im okey removing it from the public API. In my opinion it should never be used by application authors.

sstok reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@ro0NL.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

HttpFoundation: Deprecate Request::get

6 participants

@ro0NL@Nyholm@fabpot@xabbuh@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp