NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[FrameworkBundle] remove dead conditions in Translation Commands#42390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.4fromacran:5.4

Aug 6, 2021

Merged

[FrameworkBundle] remove dead conditions in Translation Commands#42390

fabpot merged 1 commit intosymfony:5.4fromacran:5.4

Aug 6, 2021

Conversation

Copy link

Contributor

acran commentedAug 5, 2021

Q	A
Branch?	5.4
Bug fix?	no
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

This is just a trivial removal of unused code I stumbled upon while debugging#42361. In theoriginal code:

$transPaths = [$path.'/translations'];$codePaths = [$path.'/templates'];if (!is_dir($transPaths[0]) && !isset($transPaths[1])) {thrownewInvalidArgumentException(sprintf('"%s" is neither an enabled bundle nor a directory.',$transPaths[0]));}

The second part of the conditionisset($transPaths[1]) willalways evaluate to true, since$targetPath is just set 3 lines above but only has a single element.

This check was originally to support legacy paths which was removed inb6eb1f4:

Rebased from 5.3 to 5.4, see#42362
/cc@fabpot

[FrameworkBundle] remove dead conditions in Translation Commands

22db5ad

Since $targetPath is directly set just 3 lines above!isset($targetPath[1]) will *always* evaluate to true.This check was originally to support legacy paths which was removed inb6eb1f4