Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Deprecate calling FormErrorIterator::children() if the current element is not iterable#42387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:5.4fromW0rma:deprecate-form-error-iterator-get-children-not-iterableAug 15, 2021
Merged
[Form] Deprecate calling FormErrorIterator::children() if the current element is not iterable#42387
fabpot merged 1 commit intosymfony:5.4fromW0rma:deprecate-form-error-iterator-get-children-not-iterableAug 15, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
W0rma commentedAug 5, 2021
| Q | A |
|---|---|
| Branch? | 5.4 for features |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | yes |
| Tickets | #42301 (comment) |
| License | MIT |
| Doc PR |
derrabus approved these changesAug 5, 2021
xabbuh requested changesAug 5, 2021
Member
xabbuh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we need to update theUPGRADE-5.4.md andUPGRADE-6.0.md files
Uh oh!
There was an error while loading.Please reload this page.
f8910cd to03a2a13CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
6de432e to9cf7d8aCompare…lement is not iterable
9cf7d8a tod8e74fcComparexabbuh approved these changesAug 14, 2021
fabpot approved these changesAug 15, 2021
Member
fabpot commentedAug 15, 2021
Thank you@W0rma. |
nicolas-grekas added a commit that referenced this pull requestAug 19, 2021
…rma)This PR was merged into the 6.0 branch.Discussion----------[Form] Remove deprecated code from FormErrorIterator| Q | A| ------------- | ---| Branch? | 6.0| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | Follow-up of#42387| License | MIT| Doc PR |Remove deprecated code from `FormErrorIterator::children()`Commits-------0798623 Throw exception if child element is not iterable
symfony-splitter pushed a commit to symfony/form that referenced this pull requestAug 19, 2021
…rma)This PR was merged into the 6.0 branch.Discussion----------[Form] Remove deprecated code from FormErrorIterator| Q | A| ------------- | ---| Branch? | 6.0| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | Follow-up ofsymfony/symfony#42387| License | MIT| Doc PR |Remove deprecated code from `FormErrorIterator::children()`Commits-------07986234cc Throw exception if child element is not iterable
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.