Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] Do not add namespace argument toNullAdapter inCachePoolPass#42365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@olsavmic
Copy link
Contributor

@olsavmicolsavmic commentedAug 4, 2021•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#42364.
LicenseMIT

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@olsavmicolsavmicforce-pushed thefix-cache-pool-pass-for-null-adapter branch fromad4e825 to5eb1e56CompareAugust 4, 2021 08:55
@olsavmicolsavmic changed the base branch from5.4 to5.3August 4, 2021 08:55
@olsavmicolsavmic changed the base branch from5.3 to5.4August 4, 2021 08:55
@olsavmicolsavmicforce-pushed thefix-cache-pool-pass-for-null-adapter branch from5eb1e56 to3cbbef7CompareAugust 4, 2021 08:57
@olsavmicolsavmic changed the base branch from5.4 to5.3August 4, 2021 08:57
@olsavmicolsavmicforce-pushed thefix-cache-pool-pass-for-null-adapter branch from3cbbef7 toe542b71CompareAugust 4, 2021 08:58
@chalasrchalasr modified the milestones:5.3,5.2Aug 4, 2021
@derrabus
Copy link
Member

The linked ticket says that the issue is present on 4.4 already. Should we rebase the PR to 4.4 then?

@carsonbotcarsonbot changed the titleDo not add namespace argument to NullAdapter in CachePoolPass[Cache] Do not add namespace argument to NullAdapter in CachePoolPassAug 4, 2021
@OskarStarkOskarStark changed the title[Cache] Do not add namespace argument to NullAdapter in CachePoolPass[Cache] Do not add namespace argument toNullAdapter inCachePoolPassAug 4, 2021
@olsavmicolsavmicforce-pushed thefix-cache-pool-pass-for-null-adapter branch frome542b71 to2f742bcCompareAugust 6, 2021 10:35
@olsavmicolsavmic changed the base branch from5.3 to4.4August 6, 2021 10:35
@olsavmic
Copy link
ContributorAuthor

The linked ticket says that the issue is present on 4.4 already. Should we rebase the PR to 4.4 then?

Correct, rebased to 4.4

derrabus reacted with thumbs up emoji

@OskarStarkOskarStark modified the milestones:5.3,4.4Aug 6, 2021
@Tobion
Copy link
Contributor

Thanks for the well done PR@olsavmic

@TobionTobion merged commit4f2987d intosymfony:4.4Aug 6, 2021
This was referencedAug 30, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus approved these changes

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@srozesrozeAwaiting requested review from sroze

@wouterjwouterjAwaiting requested review from wouterj

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

+1 more reviewer

@TobionTobionTobion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

[Cache]NullAdapter configuration in framework - Cannot replace arguments if none have been configured yet

6 participants

@olsavmic@carsonbot@derrabus@Tobion@OskarStark@chalasr
[8]ページ先頭
©2009-2025 Movatter.jp