Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DoctrineBridge] Typehint against doctrine/persistence interfaces#42360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
derrabus merged 1 commit intosymfony:5.3frommalarzm:unique-validator-types
Aug 4, 2021

Conversation

@malarzm
Copy link
Contributor

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
Ticketsdoctrine/DoctrineMongoDBBundle#689
LicenseMIT
Doc PRn/a

symfony/doctrine-bridge@564157d#diff-fcc6368334975000298e4227d2500f909f82280f79ca1d4499a9a5093a594a7dR180 went a bit too aggressive with typehints using signatures from ORM instead ofdoctrine/persistence breaking ODM's integration.

@carsonbotcarsonbot added this to the5.3 milestoneAug 3, 2021
@carsonbotcarsonbot changed the title[BC Break][doctrine-bridge] Typehint against doctrine/persistence interfaces[doctrine-bridge] Typehint against doctrine/persistence interfacesAug 3, 2021
@malarzm
Copy link
ContributorAuthor

malarzm commentedAug 3, 2021•
edited
Loading

Failing test is unrelated with the changes, it's red due to an error during composer install.

@carsonbotcarsonbot changed the title[doctrine-bridge] Typehint against doctrine/persistence interfaces[DoctrineBridge] [doctrine-bridge] Typehint against doctrine/persistence interfacesAug 3, 2021
@NyholmNyholm changed the title[DoctrineBridge] [doctrine-bridge] Typehint against doctrine/persistence interfaces[DoctrineBridge] Typehint against doctrine/persistence interfacesAug 3, 2021
@NyholmNyholm removed the BC Break labelAug 3, 2021
@Nyholm
Copy link
Member

This is not a BC break as it is just a private method.

@derrabus
Copy link
Member

Good catch, thanks@malarzm.

@derrabusderrabus merged commita5fa6e5 intosymfony:5.3Aug 4, 2021
@malarzmmalarzm deleted the unique-validator-types branchAugust 4, 2021 17:48
@fabpotfabpot mentioned this pull requestAug 30, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@NyholmNyholmNyholm approved these changes

@derrabusderrabusderrabus approved these changes

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

4 participants

@malarzm@Nyholm@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp