Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] Addlitespeed_finish_request toResponse#42332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
OskarStark commentedJul 30, 2021
ContributorAuthor
thomas2411 commentedJul 30, 2021
Oh, indeed. I have just added the email used to commit to my account on GitHub in Settings > Emails. I have verified it. Is it OK? |
litespeed_finish_request toResponsefabpot approved these changesAug 6, 2021
Member
fabpot commentedAug 6, 2021
Thank you@thomas2411. |
yannisc commentedMar 1, 2022
This change makes my OpenLiteSpeed requests to take 500ms instead of 50ms that they needed before. Any idea on why might this happen? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

For now Litespeed has dropped support for
fastcgi_finish_requestfunction due to some problems:php/php-src@ccf051c so when Litespeed is being used on a server instead of Apache, then there is no possibility to usefastcgi_finish_requestfunction as the alias forlitespeed_finish_requestis turned off.