Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[TwigBridge] do not merge label classes into expanded choice labels#42323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fancyweb merged 1 commit intosymfony:4.4fromxabbuh:issue-40005
Nov 19, 2021

Conversation

@xabbuh
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#40005
LicenseMIT
Doc PR

@xabbuhxabbuh added this to the4.4 milestoneJul 30, 2021
@xabbuhxabbuh changed the title[TwigBridge] do not merge label classes into choice labels[TwigBridge] do not merge label classes into expanded choice labelsJul 30, 2021
@xabbuh
Copy link
MemberAuthor

CI failure looks related

Status: Needs work

@xabbuh
Copy link
MemberAuthor

After having another look I fail to see how the failure is related.

Status: Needs Review

@carsonbot
Copy link

Hey!

I think@ker0x has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@xabbuh
Copy link
MemberAuthor

ping @symfony/mergers

@fancyweb
Copy link
Contributor

Thank you@xabbuh.

chalasr and wouterj reacted with rocket emoji

@fancywebfancyweb merged commiteee7b80 intosymfony:4.4Nov 19, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@welcoMatticwelcoMatticwelcoMattic approved these changes

@derrabusderrabusderrabus approved these changes

@ycerutoycerutoyceruto approved these changes

@chalasrchalasrchalasr approved these changes

+1 more reviewer

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

8 participants

@xabbuh@carsonbot@fancyweb@welcoMattic@derrabus@yceruto@ogizanagi@chalasr
[8]ページ先頭
©2009-2025 Movatter.jp