Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpFoundation] Fix str_contains type mismatch in ApacheRequest#42317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@bobvandevijver
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

When scanning for more possible error like fixed in#42316, I found this one. I decided to create a separate MR as I'm not sure falling back to/ would be the desired behaviour for a missingREQUEST_URI, or that maybe an exception would be more suitable.

@derrabus
Copy link
Member

I don't think that this change is necessary. This class is meant to be used when serving a request inside an Apache HTTPd. And in that context,REQUEST_URI should always be set.

@bobvandevijver
Copy link
ContributorAuthor

bobvandevijver commentedJul 29, 2021•
edited
Loading

Should is not must, but I agree that this will be an uncommon if not ever happening case. Anyways, feel free to close it, that's also why I made this a separate PR!

@derrabus
Copy link
Member

Let's close then. I'd rather not change that class unless someone really encounters an issue with this.

bobvandevijver reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@bobvandevijver@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp