Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Mailer] Fixed decode exception when sendgrid response is 202#42307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@rubanooo
Copy link
Contributor

QA
Branch?5.4 for features / 4.4, 5.2 or 5.3 for bug fixes
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#42306
LicenseMIT
Doc PRsymfony/symfony-docs#...

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@derrabusderrabus requested a review fromNyholmJuly 28, 2021 11:13
@derrabus
Copy link
Member

We need to target 4.4, don't we?

OskarStark reacted with thumbs up emoji

@derrabusderrabus modified the milestones:5.3,4.4Jul 28, 2021
@carsonbotcarsonbot changed the titleFixed decode exception when sendgrid response is 202[Mailer] Fixed decode exception when sendgrid response is 202Jul 28, 2021
@Nyholm
Copy link
Member

Thank you@rubanooo for fixing this.

Could you target branch 4.4 instead?

Im happy with the changes.

@fabpotfabpot changed the base branch from5.3 to4.4July 29, 2021 06:26
@fabpotfabpotforce-pushed thebugfix/sendgrid-decode-exception branch from1788fb8 to9c6d31aCompareJuly 29, 2021 06:26
@fabpot
Copy link
Member

I'm going to switch this PR to 4.4 while merging.

@fabpot
Copy link
Member

Thank you@rubanooo.

@fabpotfabpot merged commit4a28597 intosymfony:4.4Jul 29, 2021
This was referencedJul 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@NyholmNyholmAwaiting requested review from Nyholm

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@wouterjwouterjAwaiting requested review from wouterj

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@rubanooo@carsonbot@derrabus@Nyholm@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp