Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Dotenv][Yaml] Remove PHP 8.0 polyfill#42296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Signed-off-by: Alexander M. Turek <me@derrabus.de>
simonschaufi approved these changesJul 27, 2021
crmpicco commentedJul 28, 2021
Great work. Keen to see this merged in and released. |
YohannsMonnier commentedJul 28, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Dear@derrabus , this fix should also apply to 5.3.5 too. |
MemberAuthor
derrabus commentedJul 28, 2021
No worries, we're merging everything up. |
fabpot approved these changesJul 29, 2021
Member
fabpot commentedJul 29, 2021
Thank you@derrabus. |
This was referencedJul 29, 2021
Merged
Merged
Merged
Member
nicolas-grekas commentedAug 19, 2021
Linking tocomposer/composer#10024 for references. |
nicolas-grekas added a commit that referenced this pull requestAug 19, 2021
…lmann)This PR was submitted for the 5.3 branch but it was merged into the 4.4 branch instead.Discussion----------[ExpressionLanguage] [Lexer] Remove PHP 8.0 polyfill| Q | A| ------------- | ---| Branch | 5.3| Bug fix | yes| New feature | no| Deprecations | no| Tickets |Fix#42280| License | MIT| Doc PR | N/AThis is a partial revert of#41576 and is a followup to#42296Commits-------d2f39e9 Remove polyfills from ExpressionLanguage
fabpot added a commit that referenced this pull requestNov 5, 2021
…s (xabbuh)This PR was merged into the 5.4 branch.Discussion----------[Yaml] revert using functions provided by polyfill packages| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#43943| License | MIT| Doc PR |This reverts#41431 for the same reason for which we merged#42296 (see#42280 andcomposer/composer#10024 for more information).Commits-------3b9b700 revert using functions provided by polyfill packages
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial revert of#41576 and#41973.