Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpFoundation] Fixed type mismatch#42289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
derrabus merged 1 commit intosymfony:4.4fromToflar:patch-1
Jul 27, 2021
Merged

Conversation

@Toflar
Copy link
Contributor

@ToflarToflar commentedJul 27, 2021•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets#42290
LicenseMIT
Doc PR-

Fixes

Argument 1 passed to str_contains() must be of the type string, null given, called in /.../vendor/symfony/http-foundation/Response.php on line 327

in case there's nocache-control response header. This doesn't happen by default as theResponse is initialized with one by default but any class extending from it can adjust that. Technically speaking, it's not disallowed to have nocache-control header set.

Want me to add a test for that? :)

metaer and COil reacted with thumbs up emoji
@carsonbotcarsonbot changed the titleFixed type mismatch[HttpFoundation] Fixed type mismatchJul 27, 2021
@derrabus
Copy link
Member

Want me to add a test for that?

Sure, why not. 🙂

@Toflar
Copy link
ContributorAuthor

That was kind of a stupid question, I was just being lazy 🙈 Test is here now :)

sstok reacted with laugh emojiderrabus, OskarStark, and sstok reacted with heart emoji

@derrabus
Copy link
Member

Thank you@Toflar.

Toflar reacted with heart emoji

@derrabusderrabus merged commitb68cefa intosymfony:4.4Jul 27, 2021
@ToflarToflar deleted the patch-1 branchJuly 27, 2021 14:33
@metaer
Copy link
Contributor

metaer commentedJul 27, 2021•
edited
Loading

What about 5.3 branch? Is this patch going to be applied to 5.3?

COil reacted with thumbs up emoji

@derrabus
Copy link
Member

Yes.

@bobvandevijver
Copy link
Contributor

I guess this can be reverted, as it was actually a bug with thestr_contains polyfill, which just released a new version containing a fix:https://github.com/symfony/polyfill/releases/tag/v1.23.1

This was referencedJul 29, 2021
@derrabus
Copy link
Member

@bobvandevijver Actually, we need this change again for PHP 8.1 as passingnull will trigger a deprecation warning there. I think, we're good.

bobvandevijver reacted with thumbs up emoji

@bobvandevijver
Copy link
Contributor

@derrabus Ok, but in that case#42300 should probably still be fixed right?

@derrabus
Copy link
Member

Yes. Up for a PR? 🙂

bobvandevijver reacted with thumbs up emoji

@bobvandevijver
Copy link
Contributor

Done! See#42316 &#42317 😃

derrabus reacted with heart emoji

@COil
Copy link
Contributor

COil commentedAug 6, 2021

Thanks for the fix. I also had this error with Sf 5.3.5. 😉

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

7 participants

@Toflar@derrabus@metaer@bobvandevijver@COil@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp