NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Console] Dock block fix#42287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

piterpascko wants to merge2 commits intosymfony:4.4frompiterpascko:dock-block-fix

Closed

[Console] Dock block fix#42287

piterpascko wants to merge2 commits intosymfony:4.4frompiterpascko:dock-block-fix

Conversation

Copy link

piterpascko commentedJul 27, 2021

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	-.
License	MIT
Doc PR	-

Hi, there is missed comment for __constructor params $name and $description, because of that magento 2, which used in in dependency for their console command, fails to generate code because of parameters type inconsistency.

Here is a commit where that docBlock was invalidateda35a9bb#diff-f5a0e83c29f2c70f5afa8fc432e5e4929843a15971083d3b4de6e1c867214b83

piterpascko added2 commits

July 27, 2021 14:14

Update InputOption.php

51d4415

Update InputOption.php

8065749

piterpascko requested a review fromchalasr as acode owner

July 27, 2021 11:20

carsonbot added Status: Needs Review Bug labels

Jul 27, 2021

carsonbot added this to the4.4 milestone

Jul 27, 2021

Copy link

carsonbot commentedJul 27, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot