Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarDumper]HtmlDumper::setDumpHeader() acceptsnull#42274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
derrabus merged 1 commit intosymfony:5.3fromrrpadilla:5.3
Jul 28, 2021
Merged

[VarDumper]HtmlDumper::setDumpHeader() acceptsnull#42274

derrabus merged 1 commit intosymfony:5.3fromrrpadilla:5.3
Jul 28, 2021

Conversation

@rrpadilla
Copy link
Contributor

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#42272
LicenseMIT
Doc PRsymfony/symfony-docs#...

sangnguyenplus reacted with thumbs up emoji
@nicolas-grekas
Copy link
Member

Shouldn't maximebf/debugbar be patched instead? Can you please them a PR?

@nicolas-grekas
Copy link
Member

their code does check for NULL headers when printing so they are a possibility.

I read that in the issue on maximebf/debugbar, found the corresponding line in the code. This makes sense as a big fix now.

Can you please add a test case to back the behavior up?

@nicolas-grekas
Copy link
Member

I suggested an alternate fix inphp-debugbar/php-debugbar#474

@barryvdh
Copy link
Contributor

I fixed it for the time being now:php-debugbar/php-debugbar#475

I think we needed to reset it for a reason, which isn't currently possible. We're now overriding this method which solves it, but either a nullable check or a reset method would be helpful.

@derrabus
Copy link
Member

I think we needed to reset it for a reason, which isn't currently possible.

Do you want to contribute the reset method as a feature for 5.4?

@nicolas-grekas
Copy link
Member

Actually I prefer making the setter null able as a bugfix :)

derrabus reacted with thumbs up emoji

@carsonbotcarsonbot changed the titleHtmlDumper - setDumpHeader accepts null[VarDumper] HtmlDumper - setDumpHeader accepts nullJul 28, 2021
@derrabusderrabus changed the title[VarDumper] HtmlDumper - setDumpHeader accepts null[VarDumper]HtmlDumper::setDumpHeader() acceptsnullJul 28, 2021
@derrabus
Copy link
Member

Good catch, thanks@rrpadilla.

rrpadilla reacted with thumbs up emoji

@derrabusderrabus merged commita1055ae intosymfony:5.3Jul 28, 2021
@fabpotfabpot mentioned this pull requestJul 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@derrabusderrabusderrabus approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

5 participants

@rrpadilla@nicolas-grekas@barryvdh@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp