Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WebProfilerBundle] [WebProfiler] "empty" filter bugfix. Filter with name "empty" is not …#42270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromluzrain:4.4
Jul 27, 2021

Conversation

@luzrain
Copy link
Contributor

There is a bug, which make web profiler is completely broken with Mailer extension installed.
Bug is presented always in branches 5.2 and 5.3.

Art4 reacted with heart emoji
@carsonbotcarsonbot added this to the4.4 milestoneJul 26, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@OskarStark
Copy link
Contributor

Is this a duplicate of#42269?

cc@sidz

@carsonbotcarsonbot changed the title[WebProfiler] "empty" filter bugfix. Filter with name "empty" is not …[WebProfilerBundle] [WebProfiler] "empty" filter bugfix. Filter with name "empty" is not …Jul 26, 2021
@sidz
Copy link
Contributor

@OskarStark yup.

@fabpot
Copy link
Member

Thank you@luzrain.

@fabpotfabpot merged commit6f2df38 intosymfony:4.4Jul 27, 2021
This was referencedJul 27, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@luzrain@carsonbot@OskarStark@sidz@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp