Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Allow using user's serializer for message do not fit the expected JSON structure#42257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromwelcoMattic:redis-external-msg
Sep 27, 2021

Conversation

@welcoMattic
Copy link
Member

@welcoMatticwelcoMattic commentedJul 26, 2021•
edited
Loading

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#42072
LicenseMIT
Doc PRsymfony/symfony-docs#...

It allows user to use their own serializer to decode messages that do not fit the expected JSON structure ({ "message": { "body": "", "headers": {} } }).

Once this PR will be ok, I'll report the fix in Beanstalkd, SQS, and Doctrine Transports

@welcoMatticwelcoMatticforce-pushed theredis-external-msg branch 9 times, most recently from93bfcd4 to536e759CompareJuly 27, 2021 09:20
@welcoMattic
Copy link
MemberAuthor

welcoMattic commentedJul 27, 2021•
edited
Loading

@carsonbot find me a reviewer please (I'm discovering that Carson can do more things than automate status in reaction to git actions 😄 )

@carsonbot
Copy link

@jonashrem could maybe review this PR?

@welcoMatticwelcoMatticforce-pushed theredis-external-msg branch 6 times, most recently from80be65a tod529c6bCompareJuly 27, 2021 16:42
@welcoMattic
Copy link
MemberAuthor

Status: Needs review

@carsonbotcarsonbot changed the titleAllow using user's serializer for message do not fit the expected JSON structure[Messenger] Allow using user's serializer for message do not fit the expected JSON structureJul 30, 2021
@lyrixxlyrixx modified the milestones:5.3,5.4Sep 13, 2021
@welcoMattic
Copy link
MemberAuthor

This PR is ready to be reviewed

Copy link
Member

@lyrixxlyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me but I didn't test it

@fabpotfabpot changed the base branch from5.3 to5.4September 27, 2021 09:28
@fabpot
Copy link
Member

Merging in 5.4 as this is a new feature.

@fabpot
Copy link
Member

Thank you@welcoMattic.

@alexander-schranz
Copy link
Contributor

@welcoMattic Good work 👍

welcoMattic reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@lyrixxlyrixxlyrixx approved these changes

@chalasrchalasrchalasr approved these changes

@srozesrozeAwaiting requested review from sroze

+1 more reviewer

@alexander-schranzalexander-schranzalexander-schranz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[Messenger] [Redis] Can not consume messages published by third party in Redis

6 participants

@welcoMattic@carsonbot@fabpot@alexander-schranz@lyrixx@chalasr
[8]ページ先頭
©2009-2025 Movatter.jp