Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Do not fix URL protocol for relative URLs#42253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4frombogkonstantin:patch-1
Jan 31, 2022
Merged

[Form] Do not fix URL protocol for relative URLs#42253

nicolas-grekas merged 1 commit intosymfony:4.4frombogkonstantin:patch-1
Jan 31, 2022

Conversation

@bogkonstantin
Copy link
Contributor

@bogkonstantinbogkonstantin commentedJul 25, 2021•
edited by nicolas-grekas
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
TicketsFix#42329
Deprecations?no
LicenseMIT

Example when it doesn't work correctly:
/relative/path
The data will be changed to "http:///relative/path" (3 slashes)

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@OskarStark
Copy link
Contributor

Can you please add a test case?

Is this bug present in4.4? If yes, please target4.4 branch, thank you

@bogkonstantinbogkonstantin changed the base branch from5.4 to4.4July 25, 2021 10:43
@bogkonstantinbogkonstantin changed the base branch from4.4 to5.4July 25, 2021 10:43
@wouterjwouterj removed their request for reviewJuly 25, 2021 10:55
@bogkonstantinbogkonstantin changed the base branch from5.4 to4.4July 25, 2021 10:58
@OskarStarkOskarStark added this to the4.4 milestoneJul 25, 2021
@bogkonstantin
Copy link
ContributorAuthor

@OskarStark sure, done.

@carsonbotcarsonbot changed the titleDo not fix URL protocol for relative URLs[Form] Do not fix URL protocol for relative URLsJul 25, 2021
@bogkonstantin
Copy link
ContributorAuthor

AppVeyor build is failed with:

Symfony\Component\VarDumper\Tests\Server\ConnectionTest::testDumpSymfony\Component\Process\Exception\ProcessTimedOutException: The process "c:\php\php.exe" exceeded the timeout of 9 seconds.

Seems like the Form is not the reason. Can you try to rerun it, guys?

@OskarStark
Copy link
Contributor

You can ignore the AppVeyor build in this case, thanks

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(I rebased and fixed the remaining)

/**
* @dataProvider provideUrlToFix
*/
publicfunctiontestFixUrl($data)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I suggest avoiding to swap the test and its provider, to avoid merge conflicts between branches

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm going to deal with the conflicts :)

@nicolas-grekas
Copy link
Member

Thank you@bogkonstantin.

bogkonstantin reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commitc569ef1 intosymfony:4.4Jan 31, 2022
This was referencedFeb 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofstof left review comments

@OskarStarkOskarStarkOskarStark left review comments

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

+2 more reviewers

@ro0NLro0NLro0NL left review comments

@94noni94noni94noni left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

8 participants

@bogkonstantin@carsonbot@OskarStark@nicolas-grekas@stof@ro0NL@94noni@xabbuh
[8]ページ先頭
©2009-2025 Movatter.jp