Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Add Yunpian Notifier Bridge#42239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
OskarStark merged 1 commit intosymfony:5.4fromwelcoMattic:yunpian-notifier
Jul 25, 2021

Conversation

@welcoMattic
Copy link
Member

@welcoMatticwelcoMattic commentedJul 23, 2021•
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
Tickets
LicenseMIT
Doc PRsymfony/symfony-docs#15553

This PR provides support forYunpian in Notifier. Yunpian is a Chinese SMS provider.
I based this bridge on this repositoryhttps://github.com/siganushka/yunpian-notifier, I made some fixes, and add tests.

It only supports single SMS send. Yunpian provides a batch mode which I have never used.

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One minor

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for this PR

I just had minors.

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you

@OskarStark
Copy link
Contributor

Please create a recipe PR, thank you

@OskarStark
Copy link
Contributor

Thanks Mathieu for working on this feature, this is much appreciated.

welcoMattic reacted with thumbs up emoji

@OskarStarkOskarStark merged commit839d1ac intosymfony:5.4Jul 25, 2021
@welcoMatticwelcoMattic deleted the yunpian-notifier branchJuly 25, 2021 09:14
@welcoMattic
Copy link
MemberAuthor

@OskarStark The recipe PR is opensymfony/recipes#978

OskarStark reacted with heart emoji

This was referencedNov 5, 2021
@siganushka
Copy link
Contributor

@welcoMattic You did a work job, awesome!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@NyholmNyholmNyholm approved these changes

@derrabusderrabusAwaiting requested review from derrabus

@jderussejderusseAwaiting requested review from jderusse

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@welcoMattic@OskarStark@siganushka@Nyholm@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp