Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] fix table setHeaderTitle without headers#42207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalasr merged 1 commit intosymfony:4.4froma1812:fix_issue_42196
Jul 21, 2021

Conversation

@a1812
Copy link
Contributor

@a1812a1812 commentedJul 20, 2021•
edited by OskarStark
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#42196
LicenseMIT
Doc PR

fix bug

@a1812
Copy link
ContributorAuthor

Hi@OskarStark, what do you think about reworking the test "testSetTitle" and include testSetTitle2 in it ?

@OskarStark
Copy link
Contributor

IMHO the second test case in your new data provider is already included in thetestSetTitle data provider.

So a test casetestSetTitleWithoutHeaders without a data provider would be my favorite

@chalasr
Copy link
Member

Thank you@a1812.

@chalasrchalasr merged commit24a993a intosymfony:4.4Jul 21, 2021
@a1812a1812 deleted the fix_issue_42196 branchJuly 21, 2021 10:46
This was referencedJul 26, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@a1812@OskarStark@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp