Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Add FakeChat Logger transport#42188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
OskarStark merged 1 commit intosymfony:5.4fromnoniagriconomie:ft-40625-2
Aug 4, 2021

Conversation

@noniagriconomie
Copy link
Contributor

@noniagriconomienoniagriconomie commentedJul 19, 2021•
edited by OskarStark
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsSub part of#40625
LicenseMIT
Doc PRWIP

Refs#42123 for Notifier FakeChat

@noniagriconomienoniagriconomie changed the titleAdd FakeChat Logger transport[Notifier] Add FakeChat Logger transportJul 19, 2021
@OskarStark
Copy link
Contributor

Please extendUnsupportedSchemeExceptionTest, thanks

@noniagriconomienoniagriconomie changed the title[Notifier] Add FakeChat Logger transport[WIP] [Notifier] Add FakeChat Logger transportJul 19, 2021
@nicolas-grekasnicolas-grekas added this to the5.4 milestoneJul 19, 2021
@noniagriconomienoniagriconomieforce-pushed theft-40625-2 branch 3 times, most recently fromcca2045 tod43645eCompareJuly 19, 2021 12:21
@noniagriconomienoniagriconomie changed the title[WIP] [Notifier] Add FakeChat Logger transport[Notifier] Add FakeChat Logger transportJul 19, 2021
OskarStark referenced this pull requestJul 21, 2021
@carsonbotcarsonbot changed the title[Notifier] Add FakeChat Logger transportAdd FakeChat Logger transportJul 31, 2021
@carsonbotcarsonbot changed the titleAdd FakeChat Logger transport[Notifier] Add FakeChat Logger transportAug 1, 2021
Copy link
Member

@derrabusderrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you have a look at the Psalm errors?

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

see comments

@noniagriconomie
Copy link
ContributorAuthor

friendly ping@OskarStark@derrabus code reworked as requested, thx

@OskarStark
Copy link
Contributor

Thanks Antoine.

@OskarStarkOskarStark merged commit7c1820d intosymfony:5.4Aug 4, 2021
@noniagriconomienoniagriconomie deleted the ft-40625-2 branchAugust 5, 2021 07:02
OskarStark added a commit to symfony/symfony-docs that referenced this pull requestAug 7, 2021
…iconomie)This PR was merged into the 5.4 branch.Discussion----------[Notifier] Document fake chat logger notifierDocumentsymfony/symfony#42188 (no issue created post merge)Follows#15595Commits-------4e5845b Document fake chat logger notifier
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@derrabusderrabusderrabus approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@noniagriconomie@OskarStark@derrabus@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp