Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Add bridge for smsc.ru#42180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
OskarStark merged 1 commit intosymfony:5.4fromkozlice:smsc-notifier
Jul 19, 2021

Conversation

@kozlice
Copy link

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
Tickets-
LicenseMIT
Doc PRsymfony/symfony-docs#15536

Hi,

This is a notifier bridge for Russian SMS providersmsc.

This PR contains the new bridge and updates to framework bundle in all the places where all the other notifiers are listed.

@Nyholm
Copy link
Member

Great. Thank you for this PR.

It looks like a few CI jobs are complaining. Could you make sure that at least "fabbot.io" and "Package / Verify" are green?

derrabus reacted with thumbs up emoji

@kozlicekozliceforce-pushed thesmsc-notifier branch 2 times, most recently from8901968 toa7cfda2CompareJuly 18, 2021 22:57
@derrabusderrabus self-requested a reviewJuly 18, 2021 23:00
@derrabusderrabus removed their request for reviewJuly 18, 2021 23:00
@kozlice
Copy link
Author

Sure, fixed all the CI issues I could.

There still is a failed test, but it seems to be unrelated.

derrabus and Nyholm reacted with thumbs up emoji

Copy link
Member

@NyholmNyholm left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Cool cool cool.

Just a few minor things an I'll be happy.

--

Correct. That test failure is unrelated. Thank you for checking.

@kozlicekozliceforce-pushed thesmsc-notifier branch 2 times, most recently from2d53fe7 to0863f6dCompareJuly 18, 2021 23:46
@kozlicekozliceforce-pushed thesmsc-notifier branch 2 times, most recently from6b70d93 to0a69dc2CompareJuly 19, 2021 00:04
@derrabusderrabus added this to the5.4 milestoneJul 19, 2021
Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you.

Im happy with this PR. The psalm issue is addressed in#42183.

I think@OskarStark will be happy to review this PR later.

derrabus and OskarStark reacted with thumbs up emojikozlice and OskarStark reacted with heart emoji
Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just some minor comments.

  • Can you please rebase to get rid of the Psalm errors
  • Please create a recipe atsymfony/recipes-contrib repo, thanks

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please create a recipe for this bridge

@OskarStark
Copy link
Contributor

Thanks Valentin for working on this feature, this is much appreciated.

@OskarStarkOskarStark merged commitd46125a intosymfony:5.4Jul 19, 2021
OskarStark added a commit to symfony/symfony-docs that referenced this pull requestJul 19, 2021
This PR was merged into the 5.4 branch.Discussion----------[Notifier] Add bridge for smsc.ruAdd Notifier brdige for smsc.rusymfony/symfony#42180Commits-------5f443b9 [Notifier] Add bridge for smsc.ru
@kozlice
Copy link
Author

Thanks for the fast and detailed review, guys

Here's the recipe PR:symfony/recipes#975

OskarStark reacted with thumbs up emoji

This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@NyholmNyholmNyholm approved these changes

@derrabusderrabusderrabus requested changes

@OskarStarkOskarStarkOskarStark approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@kozlice@Nyholm@OskarStark@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp