Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] [Redis] Prepare turningdelete_after_ack totrue in 6.0#42163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalasr merged 1 commit intosymfony:5.4fromchalasr:del-after-ack
Jul 19, 2021

Conversation

@chalasr
Copy link
Member

@chalasrchalasr commentedJul 16, 2021•
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?no
Deprecations?yes
TicketsFix#42122
LicenseMIT
Docs PRtodo

Having this option turned on makes redis-messenger much more consistent with other transports, more adapted to the 80% use case and more importantly, prevents having to deal with OOM issues.

Seldaek and alexander-schranz reacted with thumbs up emoji
@chalasrchalasr requested a review fromsroze as acode ownerJuly 16, 2021 22:14
@carsonbotcarsonbot changed the title[Messenger][Redis] Prepare turningdelete_after_ack totrue in 6.0[Messenger] [Redis] Prepare turningdelete_after_ack totrue in 6.0Jul 16, 2021
@chalasrchalasrforce-pushed thedel-after-ack branch 2 times, most recently fromd18171f to80f94d4CompareJuly 17, 2021 12:04
@alexander-schranz
Copy link
Contributor

alexander-schranz commentedJul 17, 2021•
edited
Loading

Thank you@chalasr. Think consistents between to transports are important here and did lead in do past in unexpected errors.

@chalasrchalasr added this to the5.4 milestoneJul 18, 2021
derrabus added a commit that referenced this pull requestJul 18, 2021
This PR was merged into the 4.4 branch.Discussion----------[CI] Fix wrongly skipped integration tests| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -The integration tests from bridges located in components (e.g. `Notifier/Bridge/Discord/Tests` or `Messenger/Bridge/Redis/Tests`) were excluded from the CI.Spotted while working on#42163 - Some redis-messenger tests are currently broken on 5.x, which we didn't spot because of the missing entry in the phpunit config.Commits-------438a503 [ci] Fix wrongly skipped integration tests
Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree with this change.

I would like you two write "Redis" where it make sense. I also have one question.

@chalasr
Copy link
MemberAuthor

Thanks for the review Tobias, suggestions applied.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(with minor comments)

@chalasrchalasrforce-pushed thedel-after-ack branch 2 times, most recently from0b44408 to1439f37CompareJuly 19, 2021 09:08
@chalasr
Copy link
MemberAuthor

@nicolas-grekas Thanks, all fixed

@chalasrchalasrforce-pushed thedel-after-ack branch 3 times, most recently from755cf01 to3be461bCompareJuly 19, 2021 12:55
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@NyholmNyholmNyholm left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@srozesrozeAwaiting requested review from sroze

+1 more reviewer

@alexander-schranzalexander-schranzalexander-schranz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[Messenger] [DX] Redis default configuration lead to fill server

5 participants

@chalasr@alexander-schranz@nicolas-grekas@Nyholm@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp