Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Translation] remove unused code#42128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedJul 15, 2021
| Q | A |
|---|---|
| Branch? | 5.2 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
small mess here...
| { | ||
| $this->assertValidLocale($locale); | ||
| $this->locale =$locale ?? (class_exists(\Locale::class) ? \Locale::getDefault() :'en'); | ||
| $this->locale =$locale; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
in 4.4, we deprecated calling setLocale withnull
we could make the empty string fallback to\Locale::getDefault(), but there are tests that fail if we do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ref#38230
we could still deprecate empty string on 4.4 isnt it? also the trait currenly stll allows"" and"0", perhaps we should consider a sharedLocaleAwareTrait
nicolas-grekasJul 15, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we can't deprecate anymore on 4.4
looks like we (I) missed why#38230 was proposed...
| protectedfunctionassertValidLocale(string$locale) | ||
| { | ||
| if (null !==$locale &&1 !==preg_match('/^[a-z0-9@_\\.\\-]*$/i',$locale)) { | ||
| if (!preg_match('/^[a-z0-9@_\\.\\-]+$/i',$locale)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the empty string should not be a valid locale
nicolas-grekas commentedJul 15, 2021
Replaced by#42130 |
…s-grekas)This PR was merged into the 4.4 branch.Discussion----------[Translation] fix fallback to Locale::getDefault()| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Replaces#42128 and#38230Provides consistent behavior with `TranslatorTrait::getLocale()`.Commits-------20120a3 [Translator] fix fallback to Locale::getDefault()