Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Messenger] Add$stamps
parameter toHandleTrait::handle
#42124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Messenger] Add$stamps
parameter toHandleTrait::handle
#42124
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
e37a935
tobdaa434
Comparebdaa434
to436e506
CompareI rebased this branch. As I think this is a new feature and we are in RC phase I updated the changelog to 6.2. |
While having stamps part of the |
In our cases it is very important that we are allowed to input stamps. As they control our middlewares. We had very bad experience with "automated" middlewares like DoctrineFlush oder DoctrineTransactionMiddleware and creating for everything seperate message buses was a bad developer experience. So we decided to use stamps for this kind of things so developer had 100% control in the userinterface layer our messages are dispatched how the message is handled by the middlewares. And I don't see much which speak against it as it is still optional and if somebody don't want to use it they don't need it. |
alexander-schranz commentedDec 13, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Is there any chance to rediscuss this? We are using Stamps not only for Doctrine Flush but also for newYourMessage(), [newLockStamp('lock-key',300.0,true)]) |
2f044ea
toa652612
CompareUh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Works for me, thanks for clarifying.
1c359b7
toc4f3677
Comparec4f3677
toa61a656
Comparealexander-schranz commentedJan 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
just rebased, fabbot unrelated:#42124 (comment) |
a61a656
to9d69f84
CompareUh oh!
There was an error while loading.Please reload this page.
$stamps
parameter toHandleTrait::handle
Something I can do to push this over the line :) |
Uh oh!
There was an error while loading.Please reload this page.
c3237a6
tocb10d2e
CompareUh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
7834310
to1742f67
CompareThank you@alexander-schranz. |
c6baf1b
intosymfony:7.3Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Like the
MessageBusInterface::dispatch
it would be great to use stamps.We are using example a custom middleware to control if a flush should be done.
Also a custom middleware for locking: