Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Add FakeSMS Logger transport#42123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
OskarStark merged 1 commit intosymfony:5.4fromnoniagriconomie:ft-40625
Jul 31, 2021

Conversation

@noniagriconomie
Copy link
Contributor

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsSub part of#40625
LicenseMIT
Doc PRWIP

Friendly ping@OskarStark

As commentedhere I use mainly the sms transport, thus wanted to work on the fake sms. This PR adds thelogger.

For the partan optional channel, how can we get to here? dymanically retreiving the proper logger based on the dsn config?

@carsonbotcarsonbot changed the titleAdd FakeSMS Logger transport[Notifier] Add FakeSMS Logger transportJul 15, 2021
@noniagriconomie
Copy link
ContributorAuthor

@OskarStark done, if wanted, I can create a second PR for FakeChatLoggerTransport

OskarStark reacted with rocket emoji

@OskarStark
Copy link
Contributor

OskarStark commentedJul 16, 2021•
edited
Loading

@OskarStark done, if wanted, I can create a second PR for FakeChatLoggerTransport

Yes please do 👍🏻

@noniagriconomienoniagriconomie changed the title[Notifier] Add FakeSMS Logger transport[WIP] [Notifier] Add FakeSMS Logger transportJul 19, 2021
@noniagriconomienoniagriconomie changed the title[WIP] [Notifier] Add FakeSMS Logger transport[Notifier] Add FakeSMS Logger transportJul 19, 2021
@Nyholm
Copy link
Member

Sorry for asking. But why can't we just add a logger to the FakeSMS transport?

@OskarStark
Copy link
Contributor

In this case one need to configure the email stuff just to get the logging.

If you have no mailing in your project, you would need to set it up just for local dev to have the entry point via DSN

OskarStark referenced this pull requestJul 21, 2021
@OskarStark
Copy link
Contributor

Please add a test case to UnsupportedSchemeExceptionTest

Thanks

@noniagriconomie
Copy link
ContributorAuthor

noniagriconomie commentedJul 30, 2021•
edited
Loading

@OskarStark

PR rebased, also on

Please add a test case to UnsupportedSchemeExceptionTest

I am sorry I really do not understand this, when I check into this class Notifier\UnsupportedSchemeExceptionTest, I already see logic onFakeSmsTransportFactory

can you be more precise on the way to do the required test? thank you

edit: appveyor failure is not related to this addition

@OskarStark
Copy link
Contributor

You are right, it is just a new transport for an existing bridge 👍

@OskarStark
Copy link
Contributor

Thanks for your work on this new feature!

@OskarStarkOskarStark merged commit350674e intosymfony:5.4Jul 31, 2021
@noniagriconomienoniagriconomie deleted the ft-40625 branchAugust 1, 2021 18:14
OskarStark added a commit that referenced this pull requestAug 4, 2021
…mie)This PR was merged into the 5.4 branch.Discussion----------[Notifier] Add FakeChat Logger transport| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | Sub part of#40625| License       | MIT| Doc PR        | WIPRefs#42123 for Notifier FakeChatCommits-------2bfe06f Add FakeChat Logger transport
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestAug 4, 2021
…mie)This PR was merged into the 5.4 branch.Discussion----------[Notifier] Add FakeChat Logger transport| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | Sub part of #40625| License       | MIT| Doc PR        | WIPRefssymfony/symfony#42123 for Notifier FakeChatCommits-------2bfe06fac7 Add FakeChat Logger transport
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@derrabusderrabusderrabus approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

6 participants

@noniagriconomie@OskarStark@Nyholm@derrabus@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp