Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpFoundation] Fix return types of SessionHandler::gc()#42114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@derrabus
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets#41552
LicenseMIT
Doc PRN/A

SessionHandler::gc() should return the number of garbage-collected sessions. We often returntrue which violates that contract.

@carsonbotcarsonbot added this to the4.4 milestoneJul 14, 2021
@derrabusderrabusforce-pushed thebugfix/session-gc-return branch 4 times, most recently from7737731 to440ab14CompareJuly 15, 2021 00:10
Signed-off-by: Alexander M. Turek <me@derrabus.de>
@derrabusderrabusforce-pushed thebugfix/session-gc-return branch from440ab14 to1261a41CompareJuly 15, 2021 00:12
@nicolas-grekas
Copy link
Member

Thank you@derrabus.

@nicolas-grekasnicolas-grekas merged commit6c8114a intosymfony:4.4Jul 15, 2021
@derrabusderrabus deleted the bugfix/session-gc-return branchJuly 15, 2021 08:41
This was referencedJul 26, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@derrabus@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp